Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing env variables for proxy file #6319

Merged
merged 1 commit into from Nov 5, 2020
Merged

Conversation

DenysVuika
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

add the missing call to load env file in the proxy

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

Codecov Report

Merging #6319 into develop will increase coverage by 1.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6319      +/-   ##
===========================================
+ Coverage    76.24%   77.37%   +1.12%     
===========================================
  Files          865      148     -717     
  Lines        19582     4146   -15436     
  Branches      3889      825    -3064     
===========================================
- Hits         14931     3208   -11723     
+ Misses        3484      664    -2820     
+ Partials      1167      274     -893     
Impacted Files Coverage Δ
...dgets/dynamic-table/number-cell-validator.model.ts
...re/form/events/validate-dynamic-table-row.event.ts
...l/icons/raphael-icon-alfresco-publish.component.ts
lib/core/info-drawer/info-drawer.module.ts
...aphael/icons/raphael-icon-box-publish.component.ts
...ble/directives/header-filter-template.directive.ts
lib/core/clipboard/clipboard.service.ts
...le/directives/custom-loading-template.directive.ts
lib/core/dialogs/edit-json/edit-json.dialog.ts
...m/components/widgets/hyperlink/hyperlink.widget.ts
... and 707 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33caeca...296371e. Read the comment docs.

@eromano eromano merged commit a7510b9 into develop Nov 5, 2020
@eromano eromano deleted the fix-env-variables branch November 5, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants