Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-721] Improve End/Cancel Editing UX (part 1) - implement single menu option & dialog #6327

Merged
merged 6 commits into from Nov 10, 2020

Conversation

ursedaniel
Copy link
Contributor

@ursedaniel ursedaniel commented Nov 6, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

https://alfresco.atlassian.net/browse/ACS-721

What is the new behaviour?

We can use the component without relying on any cancel/emit buttons since we need this sort of functionality for the end editing withing ADW. (check the design in adobe within the jira ticket)

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@ursedaniel
Copy link
Contributor Author

I'm creating right now a new .md file for this component because apparently there is none.

@codecov-io
Copy link

codecov-io commented Nov 6, 2020

Codecov Report

Merging #6327 into develop will increase coverage by 1.87%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6327      +/-   ##
===========================================
+ Coverage    76.28%   78.15%   +1.87%     
===========================================
  Files          865      353     -512     
  Lines        19583     9687    -9896     
  Branches      3889     1945    -1944     
===========================================
- Hits         14939     7571    -7368     
+ Misses        3477     1528    -1949     
+ Partials      1167      588     -579     
Impacted Files Coverage Δ
...rc/lib/version-manager/version-upload.component.ts 81.25% <66.66%> (-8.75%) ⬇️
...b/extensions/src/lib/services/extension.service.ts
...am/components/activities/diagram-task.component.ts
...m/components/raphael/raphael-pentagon.component.ts
lib/core/datatable/data/object-datarow.model.ts
...nsights/src/lib/mock/diagram/diagram-throw.mock.ts
...am/components/raphael/raphael-rhombus.component.ts
...ess/components/widgets/duration/duration.widget.ts
lib/core/models/pagination.model.ts
lib/core/form/components/widgets/core/tab.model.ts
... and 504 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ee08f7...a168f8a. Read the comment docs.

@eromano eromano merged commit 53dcccd into develop Nov 10, 2020
@eromano eromano deleted the dev-durse-ACS-721 branch November 10, 2020 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants