Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-4123] Unify APS and Cloud event emitters for filters #6331

Merged
merged 9 commits into from Nov 16, 2020

Conversation

arditdomi
Copy link
Contributor

@arditdomi arditdomi commented Nov 10, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ACA-4123

What is the new behaviour?
All the filter components are unified. They both contain 2 event emitters. One emits the filter when a filter is selected because it was passed as an input to the component (called filterSelected), and one that emits the filter that is selected because the user clicked on it (called filterClicked). In many cases we need to distinguish between those 2 and that is the reason we need 2 different event emitters

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@pr-triage pr-triage bot added the PR: draft label Nov 10, 2020
@arditdomi arditdomi changed the title [ACA-4123] Cloud filters fix [ACA-4123] Unify APS and Cloud event emitters for filters Nov 10, 2020
@codecov-io
Copy link

codecov-io commented Nov 11, 2020

Codecov Report

Merging #6331 (435822e) into develop (ababde3) will increase coverage by 1.82%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6331      +/-   ##
===========================================
+ Coverage    76.29%   78.11%   +1.82%     
===========================================
  Files          867      357     -510     
  Lines        19612     9720    -9892     
  Branches      3891     1950    -1941     
===========================================
- Hits         14962     7593    -7369     
+ Misses        3483     1535    -1948     
+ Partials      1167      592     -575     
Impacted Files Coverage Δ
.../task/task-filters/mock/task-filters-cloud.mock.ts 100.00% <ø> (ø)
...vices/src/lib/mock/process/process.service.mock.ts 100.00% <ø> (ø)
...ervices/src/lib/mock/task/tasklist-service.mock.ts 100.00% <ø> (ø)
...ters/components/process-filters-cloud.component.ts 82.00% <71.42%> (-4.67%) ⬇️
...components/service-task-filters-cloud.component.ts 81.08% <85.71%> (-3.30%) ⬇️
...filters/components/task-filters-cloud.component.ts 81.08% <85.71%> (-3.30%) ⬇️
...lib/task-list/components/task-filters.component.ts 67.24% <85.71%> (+1.78%) ⬆️
...process-filters/mock/process-filters-cloud.mock.ts 100.00% <100.00%> (ø)
...vices/src/lib/mock/process/process-filters.mock.ts 100.00% <100.00%> (ø)
...ss-services/src/lib/mock/task/task-filters.mock.ts 100.00% <100.00%> (ø)
... and 519 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db1fb81...435822e. Read the comment docs.

@eromano
Copy link
Contributor

eromano commented Nov 16, 2020

/rebase

@arditdomi arditdomi merged commit 4dfa9b6 into develop Nov 16, 2020
@arditdomi arditdomi deleted the dev-adomi-ACA-4123 branch November 16, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants