New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACA-4123] Unify APS and Cloud event emitters for filters #6331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arditdomi
changed the title
[ACA-4123] Cloud filters fix
[ACA-4123] Unify APS and Cloud event emitters for filters
Nov 10, 2020
Codecov Report
@@ Coverage Diff @@
## develop #6331 +/- ##
===========================================
+ Coverage 76.29% 78.11% +1.82%
===========================================
Files 867 357 -510
Lines 19612 9720 -9892
Branches 3891 1950 -1941
===========================================
- Hits 14962 7593 -7369
+ Misses 3483 1535 -1948
+ Partials 1167 592 -575
Continue to review full report at Codecov.
|
arditdomi
force-pushed
the
dev-adomi-ACA-4123
branch
from
November 11, 2020 21:26
46d0179
to
d1fbc46
Compare
arditdomi
requested review from
DenysVuika,
eromano and
popovicsandras
as code owners
November 11, 2020 21:28
/rebase |
github-actions
bot
force-pushed
the
dev-adomi-ACA-4123
branch
from
November 16, 2020 00:52
1f6a41f
to
2a26413
Compare
eromano
approved these changes
Nov 16, 2020
…emove them from test files
arditdomi
force-pushed
the
dev-adomi-ACA-4123
branch
from
November 16, 2020 10:53
2a26413
to
d47be0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ACA-4123
What is the new behaviour?
All the filter components are unified. They both contain 2 event emitters. One emits the filter when a filter is selected because it was passed as an input to the component (called filterSelected), and one that emits the filter that is selected because the user clicked on it (called filterClicked). In many cases we need to distinguish between those 2 and that is the reason we need 2 different event emitters
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: