Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ix build #6347

Merged
merged 10 commits into from Nov 16, 2020
Merged

ix build #6347

merged 10 commits into from Nov 16, 2020

Conversation

eromano
Copy link
Contributor

@eromano eromano commented Nov 14, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

codecov-io commented Nov 15, 2020

Codecov Report

Merging #6347 (e0a51b3) into develop (d36fd9d) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6347      +/-   ##
===========================================
+ Coverage    76.29%   76.30%   +0.01%     
===========================================
  Files          867      867              
  Lines        19612    19612              
  Branches      3891     3891              
===========================================
+ Hits         14962    14965       +3     
+ Misses        3483     3479       -4     
- Partials      1167     1168       +1     
Impacted Files Coverage Δ
.../lib/task-list/components/attach-form.component.ts 43.58% <0.00%> (-7.70%) ⬇️
lib/core/services/upload.service.ts 88.82% <0.00%> (+3.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d36fd9d...e0a51b3. Read the comment docs.

@eromano eromano merged commit ababde3 into develop Nov 16, 2020
@eromano eromano deleted the dev-eromano-fix-build branch November 16, 2020 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants