Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADF-5284] Restore original plugin functionality #6348

Merged
merged 8 commits into from Nov 16, 2020

Conversation

pionnegru
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
ADF-5284

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

codecov-io commented Nov 14, 2020

Codecov Report

Merging #6348 (1205778) into develop (d36fd9d) will increase coverage by 0.16%.
The diff coverage is 57.14%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6348      +/-   ##
===========================================
+ Coverage    76.29%   76.45%   +0.16%     
===========================================
  Files          867      867              
  Lines        19612    19615       +3     
  Branches      3891     3892       +1     
===========================================
+ Hits         14962    14997      +35     
+ Misses        3483     3441      -42     
- Partials      1167     1177      +10     
Impacted Files Coverage Δ
...sions/src/lib/services/extension-loader.service.ts 53.57% <40.00%> (+42.25%) ⬆️
...b/extensions/src/lib/services/extension.service.ts 82.75% <100.00%> (ø)
lib/core/services/upload.service.ts 88.82% <0.00%> (+3.35%) ⬆️
lib/extensions/src/lib/config/extension-utils.ts 8.47% <0.00%> (+8.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ababde3...a0fb408. Read the comment docs.

@eromano
Copy link
Contributor

eromano commented Nov 16, 2020

/rebase

@eromano eromano merged commit 145e324 into develop Nov 16, 2020
@eromano eromano deleted the dev-pionnegru-ACA-4026 branch November 16, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants