Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADF-5281][ADF] Can't go through a form with date/dateTime widgets only with Tab #6365

Merged
merged 3 commits into from Dec 18, 2020

Conversation

dhrn
Copy link
Contributor

@dhrn dhrn commented Nov 19, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

https://alfresco.atlassian.net/browse/ADF-5281

What is the new behaviour?

can able to tab through the date field. for DateTime library is not working for this behavior.
I have raised pr to the library. I am waiting for new release. Hopefully soon it will be fixed

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

codecov-io commented Nov 19, 2020

Codecov Report

Merging #6365 (3e92510) into develop (1c51b2a) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6365      +/-   ##
===========================================
+ Coverage    76.23%   76.34%   +0.11%     
===========================================
  Files          868      871       +3     
  Lines        19622    19653      +31     
  Branches      3907     3895      -12     
===========================================
+ Hits         14959    15005      +46     
- Misses        3467     3468       +1     
+ Partials      1196     1180      -16     
Impacted Files Coverage Δ
lib/core/services/auth-guard-base.ts 69.69% <0.00%> (-7.73%) ⬇️
lib/core/services/auth-guard.service.ts 47.36% <0.00%> (-2.64%) ⬇️
...templates/error-content/error-content.component.ts 72.72% <0.00%> (-2.28%) ⬇️
.../task-list/components/task-list-cloud.component.ts 92.85% <0.00%> (-1.59%) ⬇️
...k-filters/base-edit-task-filter-cloud.component.ts 71.83% <0.00%> (-0.17%) ⬇️
lib/core/context-menu/context-menu.module.ts 100.00% <0.00%> (ø)
...core/directives/version-compatibility.directive.ts 66.66% <0.00%> (ø)
...ntent-node-selector/content-node-dialog.service.ts 75.86% <0.00%> (ø)
...omponents/search-filter/search-filter.component.ts 75.14% <0.00%> (ø)
...-selector/content-node-selector-panel.component.ts 85.71% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddc3c18...4e94248. Read the comment docs.

@dhrn
Copy link
Contributor Author

dhrn commented Nov 20, 2020

This depends on the fix from the kuhnroyal/mat-datetimepicker#119

@DenysVuika
Copy link
Contributor

@eromano @dhrn I think we were going to fork this component and evolve it faster? maybe we still consider that for next releases?

@eromano
Copy link
Contributor

eromano commented Nov 25, 2020

I think we need a PR also for ACA APPS AND ADW

@eromano
Copy link
Contributor

eromano commented Dec 17, 2020

/rebase

@eromano eromano merged commit 02aad08 into develop Dec 18, 2020
@eromano eromano deleted the dev-dhrn-ADF-5281 branch December 18, 2020 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants