Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-4127] [process-services] [APS1] Return Create Filters API response instead of the default payload #6370

Merged
merged 2 commits into from Nov 23, 2020

Conversation

sivakumar414ram
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

https://alfresco.atlassian.net/browse/AAE-4127

What is the new behaviour?

Returns API response instead of the payload used for creation

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

Copy link
Contributor

@eromano eromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit test are missing

@codecov-io
Copy link

codecov-io commented Nov 20, 2020

Codecov Report

Merging #6370 (2c9e1ab) into develop (6e07c3e) will increase coverage by 1.62%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6370      +/-   ##
===========================================
+ Coverage    76.42%   78.04%   +1.62%     
===========================================
  Files          871      241     -630     
  Lines        19658     6678   -12980     
  Branches      3894     1306    -2588     
===========================================
- Hits         15024     5212    -9812     
+ Misses        3460     1060    -2400     
+ Partials      1174      406     -768     
Impacted Files Coverage Δ
...ib/process-list/services/process-filter.service.ts 90.90% <100.00%> (-0.59%) ⬇️
.../src/lib/task-list/services/task-filter.service.ts 84.31% <100.00%> (-1.15%) ⬇️
...-view-selectitem/card-view-selectitem.component.ts
...t-task-filters/edit-task-filter-cloud.component.ts
lib/core/models/component.model.ts
lib/core/models/log-levels.model.ts
...ies/diagram-google-drive-publish-task.component.ts
lib/core/mock/app-config.service.mock.ts
...rm/components/mock/form-renderer.component.mock.ts
lib/core/mock/form/form.service.mock.ts
... and 623 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e07c3e...2c9e1ab. Read the comment docs.

@sivakumar414ram
Copy link
Contributor Author

unit test are missing

Added unit tests

@eromano eromano merged commit a6edfd9 into develop Nov 23, 2020
@eromano eromano deleted the dev-sk-AAE-4127 branch November 23, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants