Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-4090] [ADW - Cloud] Warning message is displayed for one second in destination picker when Upload button is enabled #6373

Merged
merged 2 commits into from Nov 24, 2020

Conversation

sivakumar414ram
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

https://alfresco.atlassian.net/browse/AAE-4090

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

codecov-io commented Nov 23, 2020

Codecov Report

Merging #6373 (62bba43) into develop (6e07c3e) will increase coverage by 1.67%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6373      +/-   ##
===========================================
+ Coverage    76.42%   78.10%   +1.67%     
===========================================
  Files          871      357     -514     
  Lines        19658     9728    -9930     
  Branches      3894     1948    -1946     
===========================================
- Hits         15024     7598    -7426     
+ Misses        3460     1539    -1921     
+ Partials      1174      591     -583     
Impacted Files Coverage Δ
...t-node-selector/content-node-selector.component.ts 68.96% <33.33%> (-4.12%) ⬇️
...-selector/content-node-selector-panel.component.ts 85.71% <100.00%> (+0.15%) ⬆️
.../src/lib/task-list/services/task-filter.service.ts 84.31% <0.00%> (-1.15%) ⬇️
...ib/process-list/services/process-filter.service.ts 90.90% <0.00%> (-0.59%) ⬇️
lib/core/models/ecm-user.model.ts
lib/extensions/src/test.ts
lib/core/search-text/search-trigger.directive.ts
lib/core/icon/icon.module.ts
...card-view-dateitem/card-view-dateitem.component.ts
lib/core/testing/core.testing.module.ts
... and 508 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e07c3e...62bba43. Read the comment docs.

@eromano eromano merged commit 67b9b88 into develop Nov 24, 2020
@eromano eromano deleted the dev-sk-AAE-4090 branch November 24, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants