Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-4096] - Add getProcessFilters method in testing for APS - filters util #6382

Merged
merged 1 commit into from Mar 22, 2021

Conversation

arditdomi
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ACA-4096

What is the new behaviour?
A testing method to get the process filters is needed in order to test the issue

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@arditdomi arditdomi changed the title [ACA-4996] - Add getProcessFilters method in testing for APS - filters util [ACA-4096] - Add getProcessFilters method in testing for APS - filters util Nov 25, 2020
@arditdomi
Copy link
Contributor Author

/rebase

@codecov-io
Copy link

codecov-io commented Mar 11, 2021

Codecov Report

Merging #6382 (d954173) into develop (0a9e8b8) will increase coverage by 1.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6382      +/-   ##
===========================================
+ Coverage    76.39%   77.44%   +1.05%     
===========================================
  Files          882      156     -726     
  Lines        20086     4341   -15745     
  Branches      4001      854    -3147     
===========================================
- Hits         15345     3362   -11983     
+ Misses        3515      687    -2828     
+ Partials      1226      292     -934     
Impacted Files Coverage Δ
lib/core/services/identity-role.service.ts
...st/components/service-task-list-cloud.component.ts
...lib/task-list/components/task-details.component.ts
.../diagram/models/chart/details-table-chart.model.ts
...vices/src/lib/mock/process/process-filters.mock.ts
lib/core/pipes/time-ago.pipe.ts
...ib/core/form/components/widgets/core/form.model.ts
lib/core/mock/identity-user.service.mock.ts
lib/core/directives/logout.directive.ts
...ts/src/lib/diagram/models/chart/pie-chart.model.ts
... and 717 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a9e8b8...d954173. Read the comment docs.

@arditdomi
Copy link
Contributor Author

/rebase

@arditdomi
Copy link
Contributor Author

/rebase

@eromano eromano merged commit 2640134 into develop Mar 22, 2021
@eromano eromano deleted the dev-adomi-ACA-4096 branch March 22, 2021 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants