Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADF-5295] Fix Session not reloaded after User logs in in other tab #6399

Merged
merged 1 commit into from Dec 2, 2020

Conversation

davidcanonieto
Copy link
Contributor

@davidcanonieto davidcanonieto commented Dec 1, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ADF-5295

What is the new behaviour?
Supposing you have two tabs with the same user in both. You log in with a different user in the second tab. The first tab should reload with the same new session for the second tab.
Because it was removing the event listener for the window storage change, the user in the first tab was not getting the storage change and therefore, not reloading.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

codecov-io commented Dec 1, 2020

Codecov Report

Merging #6399 (0b4c768) into develop (f3e5dfe) will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6399      +/-   ##
===========================================
+ Coverage    76.33%   76.53%   +0.19%     
===========================================
  Files          871      862       -9     
  Lines        19653    19390     -263     
  Branches      3896     3827      -69     
===========================================
- Hits         15002    14840     -162     
+ Misses        3471     3383      -88     
+ Partials      1180     1167      -13     
Impacted Files Coverage Δ
lib/core/services/auth-guard.service.ts 50.00% <ø> (+2.63%) ⬆️
.../components/dynamic-component/dynamic.component.ts
lib/extensions/src/lib/config/extension-utils.ts
lib/extensions/src/test.ts
...b/extensions/src/lib/services/extension.service.ts
...b/extensions/src/lib/evaluators/core.evaluators.ts
...sions/src/lib/services/extension-loader.service.ts
...ons/src/lib/services/component-register.service.ts
lib/extensions/src/lib/config/action.extensions.ts
lib/extensions/src/lib/services/rule.service.ts
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 419c47b...0b4c768. Read the comment docs.

@eromano eromano merged commit 567ea6c into develop Dec 2, 2020
@eromano eromano deleted the dev-dcano-ADF-5295 branch December 2, 2020 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants