Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACA-4171 to ACA-4174 Display the number of activated and deactivated users #6400

Merged
merged 2 commits into from Dec 1, 2020

Conversation

TomikaArome
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Thomas Hunter seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-io
Copy link

codecov-io commented Dec 1, 2020

Codecov Report

Merging #6400 (59f9b48) into develop (fd64489) will increase coverage by 1.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6400      +/-   ##
===========================================
+ Coverage    76.33%   77.35%   +1.01%     
===========================================
  Files          871      148     -723     
  Lines        19653     4159   -15494     
  Branches      3896      827    -3069     
===========================================
- Hits         15002     3217   -11785     
+ Misses        3471      668    -2803     
+ Partials      1180      274     -906     
Impacted Files Coverage Δ
...templates/error-content/error-content.component.ts
lib/core/card-view/components/base-card-view.ts
lib/core/form/events/validate-form.event.ts
lib/core/layout/layout.module.ts
...b/core/info-drawer/info-drawer-layout.component.ts
lib/core/search-text/search-trigger.directive.ts
...am/components/swimlanes/diagram-lanes.component.ts
...k-list/services/service-task-list-cloud.service.ts
lib/core/services/page-title.service.ts
lib/core/card-view/card-view.module.ts
... and 713 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd64489...59f9b48. Read the comment docs.

Copy link
Contributor

@eromano eromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this command in the readme in the cli folder?

@eromano eromano merged commit 595bd6c into develop Dec 1, 2020
@eromano eromano deleted the ACA-4174 branch December 1, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants