Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-4241] Populate date and datetime widgets on retrieve metadata #6412

Conversation

pmartinezga
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
When retrieving the metadata from a node in a content model form, the date and datetime fields are not populated with the corresponding property value.

What is the new behaviour?
The date and datetime widgets display the value of the corresponding property in the content model form

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@pmartinezga pmartinezga self-assigned this Dec 3, 2020
@pmartinezga pmartinezga force-pushed the dev-pmartinezga-AAE-4241-date-and-datetime-populate-when-retrieve-metadata branch from c32d91e to 1deca74 Compare December 14, 2020 09:08
@codecov-io
Copy link

codecov-io commented Dec 14, 2020

Codecov Report

Merging #6412 (8bbbd4a) into develop (13faf4e) will increase coverage by 0.14%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6412      +/-   ##
===========================================
+ Coverage    76.25%   76.40%   +0.14%     
===========================================
  Files          868      859       -9     
  Lines        19623    19352     -271     
  Branches      3907     3834      -73     
===========================================
- Hits         14964    14786     -178     
+ Misses        3463     3391      -72     
+ Partials      1196     1175      -21     
Impacted Files Coverage Δ
...k-filters/base-edit-task-filter-cloud.component.ts 72.00% <ø> (ø)
...m/components/widgets/date-time/date-time.widget.ts 73.07% <33.33%> (-6.09%) ⬇️
.../lib/app/components/app-details-cloud.component.ts 100.00% <100.00%> (ø)
...src/lib/app/components/app-list-cloud.component.ts 100.00% <100.00%> (ø)
...-services-cloud/src/lib/app/mock/app-model.mock.ts 100.00% <100.00%> (ø)
...d/src/lib/app/models/application-instance.model.ts 100.00% <100.00%> (+60.00%) ⬆️
...src/lib/app/services/apps-process-cloud.service.ts 72.00% <100.00%> (-1.08%) ⬇️
.../form/components/widgets/date/date-cloud.widget.ts 82.14% <100.00%> (+1.37%) ⬆️
lib/core/services/upload.service.ts 85.47% <0.00%> (-3.36%) ⬇️
...lib/process-comments/process-comments.component.ts 61.53% <0.00%> (-2.57%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c46bbaa...8bbbd4a. Read the comment docs.

@eromano
Copy link
Contributor

eromano commented Dec 17, 2020

/rebase

@github-actions github-actions bot force-pushed the dev-pmartinezga-AAE-4241-date-and-datetime-populate-when-retrieve-metadata branch from 1deca74 to 1f6d950 Compare December 17, 2020 07:12
@pmartinezga pmartinezga force-pushed the dev-pmartinezga-AAE-4241-date-and-datetime-populate-when-retrieve-metadata branch from 1f6d950 to 323d4e8 Compare December 18, 2020 06:04
@pmartinezga pmartinezga changed the title [AAE-424] Populate date and datetime widgets on retrieve metadata [AAE-4241] Populate date and datetime widgets on retrieve metadata Dec 21, 2020
@pmartinezga pmartinezga force-pushed the dev-pmartinezga-AAE-4241-date-and-datetime-populate-when-retrieve-metadata branch from 323d4e8 to 02c44a8 Compare December 21, 2020 05:54
@pmartinezga pmartinezga force-pushed the dev-pmartinezga-AAE-4241-date-and-datetime-populate-when-retrieve-metadata branch 8 times, most recently from f11c733 to 0ff917a Compare January 8, 2021 08:52
@pmartinezga
Copy link
Contributor Author

/rebase

@github-actions github-actions bot force-pushed the dev-pmartinezga-AAE-4241-date-and-datetime-populate-when-retrieve-metadata branch from 0ff917a to 8bbbd4a Compare January 9, 2021 08:04
@eromano eromano merged commit dd09c3a into develop Jan 11, 2021
@eromano eromano deleted the dev-pmartinezga-AAE-4241-date-and-datetime-populate-when-retrieve-metadata branch January 11, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants