Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old context menu #6424

Merged
merged 1 commit into from Dec 10, 2020
Merged

remove old context menu #6424

merged 1 commit into from Dec 10, 2020

Conversation

DenysVuika
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

  • remove old and no longer used version of context menu

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

codecov-io commented Dec 4, 2020

Codecov Report

Merging #6424 (a980c36) into develop (786984b) will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6424      +/-   ##
===========================================
+ Coverage    76.28%   76.42%   +0.14%     
===========================================
  Files          870      859      -11     
  Lines        19668    19349     -319     
  Branches      3912     3832      -80     
===========================================
- Hits         15004    14788     -216     
+ Misses        3467     3385      -82     
+ Partials      1197     1176      -21     
Impacted Files Coverage Δ
lib/core/context-menu/context-menu.directive.ts 62.50% <ø> (ø)
lib/core/context-menu/context-menu.module.ts 100.00% <ø> (ø)
...ons/src/lib/services/component-register.service.ts
lib/extensions/src/lib/services/rule.service.ts
lib/extensions/src/lib/config/action.extensions.ts
...b/extensions/src/lib/evaluators/core.evaluators.ts
lib/extensions/src/lib/config/extension-utils.ts
.../components/dynamic-component/dynamic.component.ts
lib/extensions/src/test.ts
...sions/src/lib/services/extension-loader.service.ts
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 786984b...a980c36. Read the comment docs.

@DenysVuika DenysVuika marked this pull request as ready for review December 10, 2020 11:49
@DenysVuika DenysVuika merged commit cf54477 into develop Dec 10, 2020
@DenysVuika DenysVuika deleted the context-menu-cleanup branch December 10, 2020 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants