ACA-4175 Show number of user's home folders during environment scan #6446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomikaArome
requested review from
DenysVuika and
popovicsandras
as code owners
|
Thomas Hunter seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
andrea-ligios
requested changes
Dec 10, 2020
lib/cli/scripts/scan-env.ts
Outdated
| async function getHomeFoldersCount(): Promise<number> { | ||
| try { | ||
| const nodesApi = new NodesApi(jsApiConnection); | ||
| const rootApiResult = await nodesApi.listNodeChildren('-root-'); |
There was a problem hiding this comment.
are we sure that there is no way to pass a relative path such as
listNodeChildren('-root-', { 'relativePath': 'User Homes' });
There was a problem hiding this comment.
Oh yes you're correct, I had missed that thanks. Updating now
There was a problem hiding this comment.
can we please have the User Homes as a constant
There was a problem hiding this comment.
Only saw this after committing. Updating again
mauriziovitale
requested changes
Dec 10, 2020
mauriziovitale
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
The environment scan shows only number of activated and deactivated users.
What is the new behaviour?
As well as the above information, the environment scan also show the number of user's home folders.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: