Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove escaped characters to fix ABN publish #6451

Merged
merged 1 commit into from Dec 11, 2020
Merged

Conversation

m-hulbert
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
ADF docs would not publish to the Builder Network due to escaped characters.

What is the new behaviour?
Replaced escaped characters.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

Codecov Report

Merging #6451 (844ea7d) into develop (cf54477) will increase coverage by 1.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6451      +/-   ##
===========================================
+ Coverage    76.20%   77.32%   +1.12%     
===========================================
  Files          868      147     -721     
  Lines        19619     4163   -15456     
  Branches      3906      830    -3076     
===========================================
- Hits         14950     3219   -11731     
+ Misses        3474      668    -2806     
+ Partials      1195      276     -919     
Impacted Files Coverage Δ
lib/core/login/models/login-error.event.ts
lib/core/info-drawer/info-drawer.module.ts
...agram/components/raphael/raphael-rect.component.ts
...b/task/task-list/models/task-preset-cloud.model.ts
lib/core/form/components/form-base.component.ts
...orm/components/widgets/text/text-mask.component.ts
...ts/widgets/multiline-text/multiline-text.widget.ts
...task-list/validators/task-description.validator.ts
lib/core/pipes/format-space.pipe.ts
...ib/core/login/directives/login-footer.directive.ts
... and 711 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf54477...844ea7d. Read the comment docs.

@m-hulbert m-hulbert merged commit 3734151 into develop Dec 11, 2020
@m-hulbert m-hulbert deleted the dev-mhulbert-fixABN branch December 11, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants