Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-4311] Make sure we have unit test coverage of the error component. #6466

Merged
merged 1 commit into from Jan 11, 2021

Conversation

sivakumar414ram
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

https://alfresco.atlassian.net/browse/AAE-4311

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

codecov-io commented Jan 5, 2021

Codecov Report

Merging #6466 (777b0c8) into develop (2839e9f) will increase coverage by 1.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6466      +/-   ##
===========================================
+ Coverage    76.26%   77.32%   +1.05%     
===========================================
  Files          868      147     -721     
  Lines        19623     4163   -15460     
  Branches      3907      830    -3077     
===========================================
- Hits         14966     3219   -11747     
+ Misses        3460      668    -2792     
+ Partials      1197      276     -921     
Impacted Files Coverage Δ
...re/viewer/components/pdf-viewer-thumb.component.ts
.../lib/task/directives/claim-task-cloud.directive.ts
...ss-services/src/lib/task-list/models/form.model.ts
...ponents/widgets/attach-file/upload-cloud.widget.ts
...omponents/widgets/core/form-outcome-event.model.ts
...e/form/components/widgets/error/error.component.ts
...ices-cloud/src/lib/process/process-cloud.module.ts
...ights/src/lib/diagram/components/raphael/anchor.ts
...ib/core/search-text/search-text-input.component.ts
...eader/components/process-header-cloud.component.ts
... and 711 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2839e9f...777b0c8. Read the comment docs.

@mauriziovitale mauriziovitale merged commit d369fa6 into develop Jan 11, 2021
@mauriziovitale mauriziovitale deleted the dev-siva-AAE-4311 branch January 11, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants