Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated tutorial (because of the renaming) #6469

Merged
merged 1 commit into from Dec 17, 2020
Merged

Conversation

fcorti
Copy link
Contributor

@fcorti fcorti commented Dec 17, 2020

Duplicated tutorial (because of the renaming)

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
N/A

What is the new behaviour?
N/A

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
Duplicated tutorial (because of the renaming).

Duplicated tutorial (because of the renaming)
@fcorti fcorti added this to the 4.3.0 milestone Dec 17, 2020
@codecov-io
Copy link

Codecov Report

Merging #6469 (11cf158) into develop (044b6a8) will increase coverage by 1.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6469      +/-   ##
===========================================
+ Coverage    76.22%   77.34%   +1.12%     
===========================================
  Files          868      147     -721     
  Lines        19622     4163   -15459     
  Branches      3907      830    -3077     
===========================================
- Hits         14956     3220   -11736     
+ Misses        3468      666    -2802     
+ Partials      1198      277     -921     
Impacted Files Coverage Δ
...wer/components/viewer-toolbar-actions.component.ts
lib/core/form/services/form.service.ts
lib/core/form/form-base.module.ts
...dgets/dynamic-table/number-cell-validator.model.ts
...ents/widgets/radio-buttons/radio-buttons.widget.ts
lib/core/pipes/multi-value.pipe.ts
...b/diagram/models/report/report-definition.model.ts
lib/core/models/component.model.ts
lib/core/services/favorites-api.service.ts
...onents/form-definition-selector-cloud.component.ts
... and 711 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 044b6a8...11cf158. Read the comment docs.

@eromano eromano merged commit 5216d3a into develop Dec 17, 2020
@eromano eromano deleted the dev-fcorti-patch-1 branch December 17, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants