Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-3975]Add process definitions to simpleapp #6473

Merged
merged 3 commits into from Jan 12, 2021
Merged

Conversation

cristinaj
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

codecov-io commented Jan 11, 2021

Codecov Report

Merging #6473 (a135d3c) into develop (13faf4e) will increase coverage by 1.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6473      +/-   ##
===========================================
+ Coverage    76.25%   77.32%   +1.06%     
===========================================
  Files          868      147     -721     
  Lines        19623     4163   -15460     
  Branches      3907      830    -3077     
===========================================
- Hits         14964     3219   -11745     
+ Misses        3463      668    -2795     
+ Partials      1196      276     -920     
Impacted Files Coverage Δ
...es-cloud/src/lib/models/date-cloud-filter.model.ts
...hts/src/lib/diagram/components/raphael/polyline.ts
lib/core/services/deleted-nodes-api.service.ts
...ib/analytics-process/services/analytics.service.ts
lib/core/mock/renditions-service.mock.ts
...ters/services/service-task-filter-cloud.service.ts
...ore/card-view/models/card-view-selectitem.model.ts
lib/core/viewer/components/img-viewer.component.ts
lib/core/mock/identity-user.service.mock.ts
...re/form/components/widgets/amount/amount.widget.ts
... and 705 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c46bbaa...a135d3c. Read the comment docs.

@cristinaj cristinaj changed the title [ACA-3975]Add optional parameter for loginSSOIdentityService method [ACA-3975]Add process definitions to simpleapp Jan 12, 2021
@eromano eromano merged commit 818abf1 into develop Jan 12, 2021
@eromano eromano deleted the dev-crisj-ACA-3975 branch January 12, 2021 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants