Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loop scenario when the login page is not present in silent login #6512

Merged
merged 6 commits into from Jan 11, 2021

Conversation

eromano
Copy link
Contributor

@eromano eromano commented Jan 8, 2021

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
Fix loop scenario when the login page is not present in silent login

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

codecov-io commented Jan 8, 2021

Codecov Report

Merging #6512 (cc06f5d) into develop (13faf4e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6512      +/-   ##
===========================================
- Coverage    76.25%   76.24%   -0.02%     
===========================================
  Files          868      868              
  Lines        19623    19614       -9     
  Branches      3907     3903       -4     
===========================================
- Hits         14964    14955       -9     
- Misses        3463     3467       +4     
+ Partials      1196     1192       -4     
Impacted Files Coverage Δ
lib/core/services/auth-guard-base.ts 75.00% <100.00%> (-2.42%) ⬇️
lib/core/services/auth-guard-ecm.service.ts 100.00% <100.00%> (ø)
lib/core/services/auth-guard.service.ts 38.88% <0.00%> (-11.12%) ⬇️
lib/core/services/upload.service.ts 85.47% <0.00%> (-3.36%) ⬇️
...lib/process-comments/process-comments.component.ts 61.53% <0.00%> (-2.57%) ⬇️
...src/lib/app/services/apps-process-cloud.service.ts 72.00% <0.00%> (-1.08%) ⬇️
...-services-cloud/src/lib/app/mock/app-model.mock.ts 100.00% <0.00%> (ø)
...src/lib/app/components/app-list-cloud.component.ts 100.00% <0.00%> (ø)
.../lib/app/components/app-details-cloud.component.ts 100.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13faf4e...cc06f5d. Read the comment docs.

@eromano eromano merged commit 8e12e51 into develop Jan 11, 2021
@eromano eromano deleted the dev-eromano-loop-fix branch January 11, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants