Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-4379] i18n fixes #6515

Merged
merged 18 commits into from Jan 11, 2021
Merged

[AAE-4379] i18n fixes #6515

merged 18 commits into from Jan 11, 2021

Conversation

DenysVuika
Copy link
Contributor

@DenysVuika DenysVuika commented Jan 8, 2021

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

  • add missing i18n support for Cloud Filters
  • update e2e to take into account localizable content
  • greatly improve e2e readability (reduce code duplication and size of the code)

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@andrea-ligios andrea-ligios self-requested a review January 8, 2021 20:32
@codecov-io
Copy link

codecov-io commented Jan 8, 2021

Codecov Report

Merging #6515 (886eb7a) into develop (13faf4e) will increase coverage by 1.69%.
The diff coverage is 95.83%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6515      +/-   ##
===========================================
+ Coverage    76.25%   77.94%   +1.69%     
===========================================
  Files          868      356     -512     
  Lines        19623     9754    -9869     
  Branches      3907     1965    -1942     
===========================================
- Hits         14964     7603    -7361     
+ Misses        3463     1548    -1915     
+ Partials      1196      603     -593     
Impacted Files Coverage Δ
...rocess-list/services/process-list-cloud.service.ts 96.55% <ø> (ø)
...t-task-filters/edit-task-filter-cloud.component.ts 92.72% <80.00%> (+0.27%) ⬆️
.../lib/app/components/app-details-cloud.component.ts 100.00% <100.00%> (ø)
...src/lib/app/components/app-list-cloud.component.ts 100.00% <100.00%> (ø)
...-services-cloud/src/lib/app/mock/app-model.mock.ts 100.00% <100.00%> (ø)
...d/src/lib/app/models/application-instance.model.ts 100.00% <100.00%> (+60.00%) ⬆️
...src/lib/app/services/apps-process-cloud.service.ts 72.00% <100.00%> (-1.08%) ⬇️
.../components/edit-process-filter-cloud.component.ts 73.39% <100.00%> (ø)
...k-filters/base-edit-task-filter-cloud.component.ts 72.00% <100.00%> (ø)
...ilters/edit-service-task-filter-cloud.component.ts 87.09% <100.00%> (+0.43%) ⬆️
... and 514 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c46bbaa...886eb7a. Read the comment docs.

Copy link
Member

@andrea-ligios andrea-ligios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eromano eromano merged commit f8526c4 into develop Jan 11, 2021
@eromano eromano deleted the i18n-fixes branch January 11, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants