[ACA-4233] Call the scan-env adf-cli command before and after each E2E job #6519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomikaArome
requested review from
DenysVuika,
eromano and
popovicsandras
as code owners
mauriziovitale
approved these changes
Jan 11, 2021
Codecov Report
@@ Coverage Diff @@
## develop #6519 +/- ##
===========================================
- Coverage 76.23% 76.22% -0.02%
===========================================
Files 868 868
Lines 19612 19612
Branches 3904 3904
===========================================
- Hits 14951 14949 -2
- Misses 3470 3471 +1
- Partials 1191 1192 +1
Continue to review full report at Codecov.
|
eromano
requested changes
Jan 12, 2021
scripts/ci/job_hooks/after_e2e.sh
Outdated
| @@ -2,3 +2,5 @@ | |||
|
|
|||
| # Upload protractor-smartrunner artifact related to this particular job to S3 | |||
| ./scripts/ci/utils/artifact-to-s3.sh -a "$SMART_RUNNER_DIRECTORY" -o "$S3_DBP_FOLDER/protractor-smartrunner-$TRAVIS_JOB_ID.tar.bz2" | |||
|
|
|||
| npx @alfresco/adf-cli scan-env --host "$E2E_HOST" -u "$E2E_ADMIN_EMAIL_IDENTITY" -p "$E2E_ADMIN_PASSWORD_IDENTITY" | |||
There was a problem hiding this comment.
in the adf pipeline the cli commands needs to be call from node modules otherwise you are not going to get the new changes
scripts/ci/job_hooks/before_e2e.sh
Outdated
| @@ -1,5 +1,7 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| npx @alfresco/adf-cli scan-env --host "$E2E_HOST" -u "$E2E_ADMIN_EMAIL_IDENTITY" -p "$E2E_ADMIN_PASSWORD_IDENTITY" | |||
There was a problem hiding this comment.
in the adf pipeline the cli commands needs to be call from node modules otherwise you are not going to get the new changes
TomikaArome
force-pushed
the
dev-thunter-ACA-4233
branch
from
2f45bf9
to
6171c21
Compare
eromano
approved these changes
Jan 14, 2021
TomikaArome
force-pushed
the
dev-thunter-ACA-4233
branch
from
6171c21
to
f84150b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
The environment will be scanned before and after each E2E job in Travis
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: