Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT-22063] - fix form cloud layout #6529

Merged
merged 1 commit into from Jan 22, 2021
Merged

[MNT-22063] - fix form cloud layout #6529

merged 1 commit into from Jan 22, 2021

Conversation

SilviuCPopa
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/MNT-22063

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

codecov-io commented Jan 13, 2021

Codecov Report

Merging #6529 (00a6244) into develop (885792b) will increase coverage by 0.18%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6529      +/-   ##
===========================================
+ Coverage    76.23%   76.41%   +0.18%     
===========================================
  Files          869      860       -9     
  Lines        19619    19363     -256     
  Branches      3906     3839      -67     
===========================================
- Hits         14956    14796     -160     
+ Misses        3469     3388      -81     
+ Partials      1194     1179      -15     
Impacted Files Coverage Δ
...d/src/lib/form/models/task-variable-cloud.model.ts 20.00% <50.00%> (+20.00%) ⬆️
...ib/core/form/components/widgets/core/form.model.ts 92.81% <100.00%> (+4.65%) ⬆️
.../lib/task-list/components/attach-form.component.ts 43.58% <0.00%> (-7.70%) ⬇️
lib/core/services/upload.service.ts 84.91% <0.00%> (-0.56%) ⬇️
lib/extensions/src/lib/services/rule.service.ts
lib/extensions/src/lib/config/action.extensions.ts
.../components/dynamic-component/dynamic.component.ts
...sions/src/lib/services/extension-loader.service.ts
...b/extensions/src/lib/services/extension.service.ts
lib/extensions/src/lib/config/extension-utils.ts
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9870510...00a6244. Read the comment docs.

@SilviuCPopa SilviuCPopa force-pushed the dev-spopa-MNT-22063 branch 2 times, most recently from 4a1d81a to 00a6244 Compare January 19, 2021 14:18
@eromano eromano merged commit b126c14 into develop Jan 22, 2021
@eromano eromano deleted the dev-spopa-MNT-22063 branch January 22, 2021 16:59
VitoAlbano added a commit that referenced this pull request Mar 8, 2021
eromano pushed a commit that referenced this pull request Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants