Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADF-5305] - Added aspect list component #6549

Merged
merged 24 commits into from Feb 17, 2021
Merged

Conversation

VitoAlbano
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@CLAassistant
Copy link

CLAassistant commented Jan 19, 2021

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Feb 3, 2021

Codecov Report

Merging #6549 (5225923) into develop (43ed8d7) will increase coverage by 0.31%.
The diff coverage is 90.29%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6549      +/-   ##
===========================================
+ Coverage    76.20%   76.51%   +0.31%     
===========================================
  Files          875      872       -3     
  Lines        19790    19658     -132     
  Branches      3939     3883      -56     
===========================================
- Hits         15080    15041      -39     
+ Misses        3506     3424      -82     
+ Partials      1204     1193      -11     
Impacted Files Coverage Δ
lib/content-services/src/lib/content.module.ts 33.33% <ø> (ø)
lib/core/core.module.ts 75.00% <ø> (ø)
lib/core/services/alfresco-api.service.ts 72.50% <0.00%> (-1.86%) ⬇️
lib/core/services/auth-guard-base.ts 76.31% <ø> (ø)
...sk-header/mocks/fake-task-details-response.mock.ts 100.00% <ø> (ø)
.../task/task-header/mocks/task-details-cloud.mock.ts 100.00% <ø> (ø)
...cess-services/src/lib/form/start-form.component.ts 58.82% <ø> (-0.80%) ⬇️
...ervices/src/lib/aspect-list/aspect-list.service.ts 81.25% <81.25%> (ø)
...rs/components/base-task-filters-cloud.component.ts 93.75% <85.71%> (-6.25%) ⬇️
...rc/lib/aspect-list/aspect-list-dialog.component.ts 86.66% <86.66%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66f4dbd...5225923. Read the comment docs.

@VitoAlbano VitoAlbano force-pushed the dev-valbano-ADF-5305 branch 2 times, most recently from 7c2957e to 483e718 Compare February 11, 2021 22:50
@VitoAlbano VitoAlbano marked this pull request as ready for review February 11, 2021 23:37
@VitoAlbano VitoAlbano changed the title [DRAFT][ADF-5305] - Added aspect list component [ADF-5305] - Added aspect list component Feb 11, 2021
Copy link
Contributor

@eromano eromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some string in the demo shell part that should go in the JSON file and for now please don't modify the pair dependencies of the packages is not needed they get update before the releases

package-lock.json Outdated Show resolved Hide resolved
@eromano eromano merged commit e62c752 into develop Feb 17, 2021
@eromano eromano deleted the dev-valbano-ADF-5305 branch February 17, 2021 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants