Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADF-5324] - Expose a new adf-cli command to initialise acs-env #6551

Merged
merged 4 commits into from Jan 21, 2021

Conversation

mauriziovitale
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@mauriziovitale mauriziovitale changed the title Expose a new adf-cli command to initialise acs-env [ADF-5324] - Expose a new adf-cli command to initialise acs-env Jan 20, 2021
@codecov-io
Copy link

codecov-io commented Jan 20, 2021

Codecov Report

Merging #6551 (805222c) into develop (28679df) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6551   +/-   ##
========================================
  Coverage    76.25%   76.25%           
========================================
  Files          869      869           
  Lines        19625    19625           
  Branches      3908     3908           
========================================
  Hits         14966    14966           
- Misses        3464     3466    +2     
+ Partials      1195     1193    -2     
Impacted Files Coverage Δ
...src/lib/document-list/data/share-data-row.model.ts 73.68% <0.00%> (-2.64%) ⬇️
lib/core/services/upload.service.ts 85.47% <0.00%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28679df...805222c. Read the comment docs.

@eromano eromano merged commit 5712b50 into develop Jan 21, 2021
@eromano eromano deleted the ADF-5324-init-acs branch January 21, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants