Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-4384] Add blank page component #6559

Merged
merged 1 commit into from Jan 22, 2021
Merged

Conversation

TomikaArome
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Blank page component previously available on certain other apps (such as ADW) has now been added to ADF

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

codecov-io commented Jan 21, 2021

Codecov Report

Merging #6559 (19ca1b9) into develop (cf1bb70) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6559      +/-   ##
===========================================
+ Coverage    76.26%   76.42%   +0.15%     
===========================================
  Files          869      861       -8     
  Lines        19625    19364     -261     
  Branches      3908     3839      -69     
===========================================
- Hits         14967    14798     -169     
+ Misses        3464     3386      -78     
+ Partials      1194     1180      -14     
Impacted Files Coverage Δ
lib/core/blank-page/blank-page.component.ts 100.00% <100.00%> (ø)
lib/core/services/upload.service.ts 84.91% <0.00%> (-0.56%) ⬇️
...sions/src/lib/services/extension-loader.service.ts
.../components/dynamic-component/dynamic.component.ts
lib/extensions/src/lib/services/rule.service.ts
...b/extensions/src/lib/services/extension.service.ts
lib/extensions/src/test.ts
...ons/src/lib/services/component-register.service.ts
lib/extensions/src/lib/config/extension-utils.ts
...b/extensions/src/lib/evaluators/core.evaluators.ts
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf1bb70...19ca1b9. Read the comment docs.

@TomikaArome TomikaArome merged commit b11ef04 into develop Jan 22, 2021
@TomikaArome TomikaArome deleted the dev-thunter-AAE-4384 branch January 22, 2021 11:57
mauriziovitale added a commit that referenced this pull request Jan 22, 2021
mauriziovitale added a commit that referenced this pull request Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants