Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do redirect before implicit button #6574

Merged
merged 3 commits into from Jan 25, 2021
Merged

Conversation

mauriziovitale
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

codecov-io commented Jan 25, 2021

Codecov Report

Merging #6574 (db06124) into develop (8f0633b) will increase coverage by 1.96%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6574      +/-   ##
===========================================
+ Coverage    76.25%   78.22%   +1.96%     
===========================================
  Files          869      493     -376     
  Lines        19629    11514    -8115     
  Branches      3910     2182    -1728     
===========================================
- Hits         14969     9007    -5962     
+ Misses        3465     1820    -1645     
+ Partials      1195      687     -508     
Impacted Files Coverage Δ
.../lib/task-list/components/attach-form.component.ts 43.58% <0.00%> (ø)
...ble/directives/header-filter-template.directive.ts
...re/form/components/widgets/number/number.widget.ts
lib/core/toolbar/toolbar.module.ts
...ore/directives/infinite-select-scroll.directive.ts
lib/core/services/login-dialog.service.ts
lib/core/form/events/form.event.ts
...ib/core/login/directives/login-header.directive.ts
.../directives/tooltip-card/tooltip-card.component.ts
lib/core/directives/directive.module.ts
... and 366 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f0633b...d311b1f. Read the comment docs.

@mauriziovitale mauriziovitale merged commit 419fc16 into develop Jan 25, 2021
@mauriziovitale mauriziovitale deleted the ADF-4450-siler-or-implicit branch January 25, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants