Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADF-4329][ASD-5330] plus Improve e2e #6580

Merged
merged 12 commits into from Feb 5, 2021
Merged

Conversation

eromano
Copy link
Contributor

@eromano eromano commented Jan 26, 2021

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
Improve PS e2e

What is the new behaviour?
https://alfresco.atlassian.net/browse/ADF-5329
https://alfresco.atlassian.net/browse/ADF-5330

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

codecov-io commented Jan 27, 2021

Codecov Report

Merging #6580 (8c27403) into develop (3946fc7) will increase coverage by 2.46%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6580      +/-   ##
===========================================
+ Coverage    76.27%   78.74%   +2.46%     
===========================================
  Files          871      346     -525     
  Lines        19673     7390   -12283     
  Branches      3928     1359    -2569     
===========================================
- Hits         15005     5819    -9186     
+ Misses        3467     1160    -2307     
+ Partials      1201      411     -790     
Impacted Files Coverage Δ
...lib/task-list/components/task-details.component.ts 75.42% <0.00%> (-0.85%) ⬇️
.../lib/task-list/components/task-header.component.ts 82.97% <54.54%> (-6.50%) ⬇️
.../attach-file/attach-file-cloud-widget.component.ts 85.52% <0.00%> (-1.15%) ⬇️
lib/core/form/components/form-list.component.ts
lib/core/mock/alfresco-api.service.mock.ts
...ad/components/file-uploading-list-row.component.ts
lib/content-services/src/lib/material.module.ts
...omponents/filesize-cell/filesize-cell.component.ts
lib/core/context-menu/animations.ts
lib/core/directives/node-restore.directive.ts
... and 512 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3946fc7...8c27403. Read the comment docs.

@eromano eromano marked this pull request as ready for review February 4, 2021 17:27
@eromano eromano changed the title Improve PS e2e [ADF-4329][ASD-5330] plus Improve e2e Feb 4, 2021
@eromano eromano merged commit f4976a1 into develop Feb 5, 2021
@eromano eromano deleted the dev-eromano-improve-ps-e2e branch February 5, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants