Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADF-5331] - Alpha ADF/JS-API update has been successfully created. #6639

Merged
merged 6 commits into from Feb 8, 2021

Conversation

eromano
Copy link
Contributor

@eromano eromano commented Feb 6, 2021

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

In order to improve the ADF/JS-API Alpha build we have decided to change :

The name of the Alpha build will contain the build number and not the hash

The JS-API will be updated by an automatic task run by the JS-API at its end

ADF will not automatically update anymore the JS-API

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

refactor the alpha build to use the JS-API in the branch all the time
@codecov-io
Copy link

codecov-io commented Feb 8, 2021

Codecov Report

Merging #6639 (ad3c30c) into develop (dcbe91a) will decrease coverage by 0.06%.
The diff coverage is 70.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6639      +/-   ##
===========================================
- Coverage    76.31%   76.24%   -0.07%     
===========================================
  Files          869      871       +2     
  Lines        19630    19702      +72     
  Branches      3910     3934      +24     
===========================================
+ Hits         14980    15022      +42     
- Misses        3455     3476      +21     
- Partials      1195     1204       +9     
Impacted Files Coverage Δ
.../core/card-view/models/card-view-baseitem.model.ts 77.27% <ø> (ø)
...ore/card-view/services/card-view-update.service.ts 100.00% <ø> (ø)
lib/core/core.module.ts 75.00% <ø> (ø)
...ib/core/userinfo/components/user-info.component.ts 81.57% <0.00%> (-4.54%) ⬇️
.../task/task-filters/mock/task-filters-cloud.mock.ts 100.00% <ø> (ø)
...lib/task-list/components/task-details.component.ts 75.42% <0.00%> (-0.85%) ⬇️
.../lib/search/search-header-query-builder.service.ts 73.46% <25.00%> (-1.54%) ⬇️
...task-filters/services/task-filter-cloud.service.ts 68.18% <33.33%> (-6.40%) ⬇️
.../lib/document-list/data/share-datatable-adapter.ts 69.92% <40.00%> (-2.05%) ⬇️
.../lib/task-list/components/task-header.component.ts 82.97% <54.54%> (-6.50%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8b9c56...ad3c30c. Read the comment docs.

scripts/next_version.sh Show resolved Hide resolved
scripts/check-js-api-version.js Outdated Show resolved Hide resolved
@eromano eromano merged commit 2071596 into develop Feb 8, 2021
@eromano eromano deleted the dev-eromano-script-refactor branch February 8, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants