Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADF-5332] Login basic auth - Ability to override the successRoute from app.config.json #6651

Merged
merged 6 commits into from Feb 12, 2021

Conversation

mauriziovitale
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

codecov-io commented Feb 9, 2021

Codecov Report

Merging #6651 (501c0fc) into develop (0b66ee8) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6651      +/-   ##
===========================================
+ Coverage    76.25%   76.39%   +0.14%     
===========================================
  Files          871      866       -5     
  Lines        19724    19529     -195     
  Branches      3935     3870      -65     
===========================================
- Hits         15040    14919     -121     
+ Misses        3479     3423      -56     
+ Partials      1205     1187      -18     
Impacted Files Coverage Δ
lib/core/login/components/login.component.ts 91.45% <100.00%> (+1.79%) ⬆️
lib/core/services/alfresco-api.service.ts 74.35% <0.00%> (-1.96%) ⬇️
...t-node-selector/content-node-selector.component.ts 64.58% <0.00%> (-1.38%) ⬇️
lib/content-services/src/lib/content.module.ts 33.33% <0.00%> (ø)
...ontent-services/src/lib/mock/content-model.mock.ts 100.00% <0.00%> (ø)
...ore/card-view/models/card-view-selectitem.model.ts 66.66% <0.00%> (ø)
...tent-metadata/services/basic-properties.service.ts 100.00% <0.00%> (ø)
.../components/dynamic-component/dynamic.component.ts
...ons/src/lib/services/component-register.service.ts
lib/extensions/src/lib/config/action.extensions.ts
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b66ee8...18f5259. Read the comment docs.

@eromano eromano merged commit 3c5d5dc into develop Feb 12, 2021
@eromano eromano deleted the mvitale-ADF-5332-login-success branch February 12, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants