Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-3881] Able to start form with preselected ACS nodes #6700

Merged
merged 5 commits into from Feb 19, 2021

Conversation

mauriziovitale
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

Copy link
Contributor

@eromano eromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing description and unit test

@codecov-io
Copy link

codecov-io commented Feb 19, 2021

Codecov Report

Merging #6700 (87e1820) into develop (e62c752) will increase coverage by 1.67%.
The diff coverage is 76.47%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6700      +/-   ##
===========================================
+ Coverage    76.34%   78.01%   +1.67%     
===========================================
  Files          881      249     -632     
  Lines        19920     6865   -13055     
  Branches      3952     1332    -2620     
===========================================
- Hits         15207     5356    -9851     
+ Misses        3505     1085    -2420     
+ Partials      1208      424     -784     
Impacted Files Coverage Δ
...cess-services/src/lib/form/start-form.component.ts 61.53% <63.63%> (+2.71%) ⬆️
...services/src/lib/form/start-form.component.mock.ts 100.00% <100.00%> (ø)
...process-list/components/start-process.component.ts 82.28% <100.00%> (+0.10%) ⬆️
...services/src/lib/aspect-list/aspect-list.module.ts 100.00% <0.00%> (ø)
...ervices/src/lib/aspect-list/node-aspect.service.ts 100.00% <0.00%> (ø)
lib/process-services-cloud/src/test.ts
...core/directives/version-compatibility.directive.ts
.../widgets/dynamic-table/editors/date/date.editor.ts
...ble/directives/header-filter-template.directive.ts
lib/core/mock/renditions-service.mock.ts
... and 630 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e62c752...2af585d. Read the comment docs.

Copy link
Contributor

@sivakumar414ram sivakumar414ram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comments

@mauriziovitale mauriziovitale changed the title [ACA-3881] Move the node to ps before loading [ACA-3881] Able to start form with preselected nodes Feb 19, 2021
@mauriziovitale mauriziovitale changed the title [ACA-3881] Able to start form with preselected nodes [ACA-3881] Able to start form with preselected ACS nodes Feb 19, 2021
@mauriziovitale mauriziovitale merged commit 75f0112 into develop Feb 19, 2021
@mauriziovitale mauriziovitale deleted the mvitale-ACA-3881-fix branch February 19, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants