Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AAE-4608] Use smartrunner version 2 and add SuperCache (workspaces + S3 combo)! #6704

Merged
merged 17 commits into from Feb 22, 2021
Merged

[AAE-4608] Use smartrunner version 2 and add SuperCache (workspaces + S3 combo)! #6704

merged 17 commits into from Feb 22, 2021

Conversation

popovicsandras
Copy link
Contributor

@popovicsandras popovicsandras commented Feb 19, 2021 •
edited

@popovicsandras popovicsandras marked this pull request as ready for review February 19, 2021 10:22
@codecov-io
Copy link

codecov-io commented Feb 19, 2021 •
edited

Codecov Report

Merging #6704 (0a1e9a4) into develop (588db58) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6704      +/-   ##
===========================================
- Coverage    76.41%   76.39%   -0.02%     
===========================================
  Files          882      882              
  Lines        20007    20007              
  Branches      3965     3965              
===========================================
- Hits         15288    15284       -4     
- Misses        3509     3512       +3     
- Partials      1210     1211       +1
Impacted Files Coverage Δ
.../lib/task-list/components/attach-form.component.ts 43.58% <0.00%> (-7.70%) ⬇️
lib/core/services/upload.service.ts 84.91% <0.00%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 588db58...0a1e9a4. Read the comment docs.

@popovicsandras popovicsandras marked this pull request as draft February 19, 2021 19:42
@popovicsandras popovicsandras changed the title [AAE-4608] Use smartrunner version 2 [AAE-4608] Use smartrunner version 2 and add Travis workspace usage Feb 19, 2021
@popovicsandras popovicsandras marked this pull request as ready for review February 20, 2021 14:01
@popovicsandras popovicsandras changed the title [AAE-4608] Use smartrunner version 2 and add Travis workspace usage [AAE-4608] Use smartrunner version 2 and add SuperCache (workspaces + S3 combo)! Feb 20, 2021
@popovicsandras popovicsandras marked this pull request as draft February 20, 2021 21:59
@popovicsandras popovicsandras marked this pull request as ready for review February 21, 2021 12:52
@eromano eromano merged commit f84ea5d into develop Feb 22, 2021
@eromano eromano deleted the dev-apopovics-AAE-4608 branch February 22, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eromano eromano eromano approved these changes

@cristinaj cristinaj Awaiting requested review from cristinaj

@DenysVuika DenysVuika Awaiting requested review from DenysVuika DenysVuika is a code owner

@mauriziovitale mauriziovitale Awaiting requested review from mauriziovitale

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@popovicsandras @codecov-io @eromano