Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REPO-5552] more filtering capabilities for aspect/type api #6713

Merged
merged 2 commits into from Feb 25, 2021

Conversation

dhrn
Copy link
Contributor

@dhrn dhrn commented Feb 22, 2021

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
depends Alfresco/alfresco-js-api#1007

@dhrn dhrn force-pushed the dev-dhrn-REPO-5552-more-filters branch from 01cc79d to f2620d6 Compare February 25, 2021 07:30
@dhrn dhrn marked this pull request as ready for review February 25, 2021 07:43
@dhrn dhrn changed the title WIP [REPO-5552] more filtering capabilities for aspect/type api [REPO-5552] more filtering capabilities for aspect/type api Feb 25, 2021
@codecov-io
Copy link

codecov-io commented Feb 25, 2021

Codecov Report

Merging #6713 (f2620d6) into develop (1b39828) will increase coverage by 1.64%.
The diff coverage is 73.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6713      +/-   ##
===========================================
+ Coverage    76.37%   78.02%   +1.64%     
===========================================
  Files          882      367     -515     
  Lines        20055    10096    -9959     
  Branches      3988     2036    -1952     
===========================================
- Hits         15317     7877    -7440     
+ Misses        3518     1584    -1934     
+ Partials      1220      635     -585     
Impacted Files Coverage Δ
...metadata/services/content-type-property.service.ts 8.69% <0.00%> (ø)
...ervices/src/lib/aspect-list/aspect-list.service.ts 85.00% <81.81%> (+0.78%) ⬆️
...vices/src/lib/content-type/content-type.service.ts 100.00% <100.00%> (ø)
...b/core/pagination/infinite-pagination.component.ts
lib/core/datatable/data/object-datarow.model.ts
...re/viewer/components/pdf-viewer-password-dialog.ts
.../core/card-view/models/card-view-textitem.model.ts
...ts/src/lib/diagram/models/chart/pie-chart.model.ts
...ram/components/raphael/raphael-circle.component.ts
lib/core/context-menu/context-menu.directive.ts
... and 508 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b39828...f2620d6. Read the comment docs.

@eromano eromano merged commit c932cb0 into develop Feb 25, 2021
@eromano eromano deleted the dev-dhrn-REPO-5552-more-filters branch February 25, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants