Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-4299] Fix C593066 e2e test - task counter #6741

Merged
merged 1 commit into from Feb 26, 2021
Merged

Conversation

davidcanonieto
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ACA-4299

What is the new behaviour?
Fix C593066 e2e test - task counter

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

Codecov Report

Merging #6741 (674f472) into develop (008b8dc) will increase coverage by 1.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6741      +/-   ##
===========================================
+ Coverage    76.38%   77.43%   +1.04%     
===========================================
  Files          882      156     -726     
  Lines        20063     4338   -15725     
  Branches      3990      853    -3137     
===========================================
- Hits         15325     3359   -11966     
+ Misses        3516      688    -2828     
+ Partials      1222      291     -931     
Impacted Files Coverage Δ
...src/lib/document-list/data/share-data-row.model.ts 73.68% <0.00%> (-2.64%) ⬇️
lib/core/events/base.event.ts
lib/core/mock/comment-content-service.mock.ts
lib/core/models/bpm-user.model.ts
lib/core/form/components/form-list.component.ts
...src/lib/services/local-preference-cloud.service.ts
...lib/process/directives/cancel-process.directive.ts
...rocess/components/start-process-cloud.component.ts
lib/core/context-menu/context-menu-overlay.ts
lib/core/form/services/form.service.ts
... and 717 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 008b8dc...674f472. Read the comment docs.

@eromano eromano merged commit 717f928 into develop Feb 26, 2021
@eromano eromano deleted the dev-dcano-ACA-4299-B branch February 26, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants