[ACA-3188] Add methods for ADW+APS1 e2e #6816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuliaib
force-pushed
the
dev-iuliaib-ACA-3188
branch
from
678aabd
to
95d863a
Compare
iuliaib
requested review from
DenysVuika,
eromano and
popovicsandras
as code owners
eromano
requested changes
Mar 22, 2021
lib/testing/src/lib/core/pages/form/widgets/attach-file-widget.page.ts
Outdated
Show resolved
Hide resolved
cristinaj
reviewed
Mar 22, 2021
lib/testing/src/lib/process-services/pages/start-process.page.ts
Outdated
Show resolved
Hide resolved
iuliaib
force-pushed
the
dev-iuliaib-ACA-3188
branch
from
cfa2221
to
8e246ad
Compare
cristinaj
approved these changes
Mar 23, 2021
iuliaib
force-pushed
the
dev-iuliaib-ACA-3188
branch
from
967cb4f
to
b0c99c9
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6816 +/- ##
===========================================
+ Coverage 76.61% 77.80% +1.18%
===========================================
Files 887 156 -731
Lines 20249 4343 -15906
Branches 4036 855 -3181
===========================================
- Hits 15514 3379 -12135
+ Misses 3495 671 -2824
+ Partials 1240 293 -947 Continue to review full report at Codecov.
|
eromano
requested changes
Mar 23, 2021
lib/testing/src/lib/core/pages/form/widgets/attach-file-widget.page.ts
Outdated
Show resolved
Hide resolved
iuliaib
force-pushed
the
dev-iuliaib-ACA-3188
branch
from
cec2c5f
to
a73e786
Compare
iuliaib
force-pushed
the
dev-iuliaib-ACA-3188
branch
from
a73e786
to
5e913f9
Compare
iuliaib
force-pushed
the
dev-iuliaib-ACA-3188
branch
from
5e913f9
to
afc1ee4
Compare
eromano
requested changes
Apr 7, 2021
added 13 commits
April 9, 2021 10:18
iuliaib
force-pushed
the
dev-iuliaib-ACA-3188
branch
from
c6f6eed
to
fcf5ef6
Compare
|
@eromano based on the meeting that we had yesterday I've deleted the |
TomikaArome
pushed a commit
that referenced
this pull request
Apr 9, 2021
* Add isRemoveFileOptionDisplayed method * Add checkStartProcessFormIsDisplayed method * delete unused class * add setUserTaskName to e2e-displayValue-process * delete unused class * update isRemoveFileOptionDisplayed method * Create separate PO for start-form component * Export new PO * tslint fix * convert selectors to TestElement * improve test-element isDisplayed method * rename method * Remove methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: