Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT-22236] Permission i18n support #6843

Merged
merged 9 commits into from Mar 23, 2021
Merged

[MNT-22236] Permission i18n support #6843

merged 9 commits into from Mar 23, 2021

Conversation

DenysVuika
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

  • provide i18n support for permissions/roles
  • special directive to do the role translations

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://alfresco.atlassian.net/browse/MNT-22236

@codecov-io
Copy link

Codecov Report

Merging #6843 (1fb0c63) into develop (c0a3f9d) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head 1fb0c63 differs from pull request most recent head f687ff2. Consider uploading reports for the commit f687ff2 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6843      +/-   ##
===========================================
- Coverage    76.39%   76.32%   -0.08%     
===========================================
  Files          882      718     -164     
  Lines        20086    15491    -4595     
  Branches      4001     3080     -921     
===========================================
- Hits         15345    11823    -3522     
+ Misses        3515     2748     -767     
+ Partials      1226      920     -306     
Impacted Files Coverage Δ
lib/core/pipes/pipe.module.ts 100.00% <ø> (ø)
lib/core/pipes/localized-role.pipe.ts 100.00% <100.00%> (ø)
...tent-node-selector/content-node-selector.module.ts
...vices/src/lib/search/search-query-service.token.ts
...ib/upload/components/upload-drag-area.component.ts
...ad/components/file-uploading-list-row.component.ts
...ent-services/src/lib/webscript/webscript.module.ts
...sions/src/lib/services/extension-loader.service.ts
...src/lib/document-list/data/share-data-row.model.ts
...ntent-node-selector/content-node-dialog.service.ts
... and 155 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0a3f9d...f687ff2. Read the comment docs.

@DenysVuika DenysVuika merged commit b97aa7d into develop Mar 23, 2021
@DenysVuika DenysVuika deleted the permission-i18n branch March 23, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants