Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-4017] Change label: attach file retrieve metadata #6850

Merged

Conversation

rbarroso
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:
    Change labels

What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/AAE-4017

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@CLAassistant
Copy link

CLAassistant commented Mar 24, 2021

CLA assistant check
All committers have signed the CLA.

@rbarroso rbarroso self-assigned this Mar 24, 2021
@rbarroso rbarroso changed the title [AAE-4017] Change label attach file retrieve metadata [AAE-4017] Change label: attach file retrieve metadata Mar 24, 2021
@codecov-io
Copy link

codecov-io commented Mar 24, 2021

Codecov Report

Merging #6850 (8c035b6) into develop (ab6354d) will increase coverage by 1.63%.
The diff coverage is n/a.

❗ Current head 8c035b6 differs from pull request most recent head 44fbcaf. Consider uploading reports for the commit 44fbcaf to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6850      +/-   ##
===========================================
+ Coverage    76.39%   78.02%   +1.63%     
===========================================
  Files          883      367     -516     
  Lines        20088    10130    -9958     
  Branches      4003     2050    -1953     
===========================================
- Hits         15346     7904    -7442     
+ Misses        3515     1585    -1930     
+ Partials      1227      641     -586     
Impacted Files Coverage Δ
...rm/services/content-cloud-node-selector.service.ts 27.77% <0.00%> (-5.56%) ⬇️
...rc/lib/form/mocks/attach-file-cloud-widget.mock.ts 100.00% <0.00%> (ø)
...re/form/components/widgets/core/container.model.ts
...ets/dynamic-table/required-cell-validator.model.ts
lib/core/pagination/pagination.component.ts
...e/form/components/widgets/error/error.component.ts
...am/components/raphael/raphael-rhombus.component.ts
.../core/dialogs/edit-json/edit-json.dialog.module.ts
lib/core/mock/authentication.service.mock.ts
lib/core/dialogs/edit-json/edit-json.dialog.ts
... and 510 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab6354d...44fbcaf. Read the comment docs.

@eromano eromano merged commit b12c37e into develop Mar 25, 2021
@eromano eromano deleted the dev-rbarroso-AAE-4017-attach-file-menu-fill-metadata-label branch March 25, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants