Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT-22236] update e2e to reflect permission i18n support #6852

Merged
merged 5 commits into from Mar 24, 2021

Conversation

DenysVuika
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

  • fix the e2e
  • remove some deprecated uses of the js-api

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://alfresco.atlassian.net/browse/MNT-22236

@codecov-io
Copy link

Codecov Report

Merging #6852 (72b8c76) into develop (ab6354d) will increase coverage by 0.99%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6852      +/-   ##
===========================================
+ Coverage    76.39%   77.39%   +0.99%     
===========================================
  Files          883      156     -727     
  Lines        20088     4335   -15753     
  Branches      4003      854    -3149     
===========================================
- Hits         15346     3355   -11991     
+ Misses        3515      689    -2826     
+ Partials      1227      291     -936     
Impacted Files Coverage Δ
...onents/activities/diagram-manual-task.component.ts
...st/components/process-instance-header.component.ts
lib/core/mock/event.mock.ts
...src/lib/diagram/components/raphael/raphael-base.ts
...ss-services/src/lib/mock/task/task-details.mock.ts
lib/core/models/ecm-user.model.ts
...orm/components/widgets/document/document.widget.ts
lib/core/test.ts
lib/core/mock/form/form.component.mock.ts
...ib/process-services/src/lib/form/form.component.ts
... and 717 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab6354d...72b8c76. Read the comment docs.

@DenysVuika DenysVuika merged commit 6ec9833 into develop Mar 24, 2021
@DenysVuika DenysVuika deleted the membership-e2e branch March 24, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants