Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-4370] Refresh filter counter on filter click #6873

Merged
merged 1 commit into from Mar 29, 2021

Conversation

davidcanonieto
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ACA-4370

What is the new behaviour?
We should refresh the counter of filter click to sync this component with the task list’s pagination. This way, the counter always reflects reality and shows the correct number when clicking on it. This issue fixes problems like this, where the counter is showing 2 and the task list is showing 0.
image (150)

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

codecov-io commented Mar 29, 2021

Codecov Report

Merging #6873 (510730d) into develop (b4fa193) will increase coverage by 1.68%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6873      +/-   ##
===========================================
+ Coverage    76.41%   78.09%   +1.68%     
===========================================
  Files          885      367     -518     
  Lines        20209    10136   -10073     
  Branches      4027     2051    -1976     
===========================================
- Hits         15442     7916    -7526     
+ Misses        3535     1579    -1956     
+ Partials      1232      641     -591     
Impacted Files Coverage Δ
...task-filters/services/task-filter-cloud.service.ts 70.00% <ø> (ø)
...filters/components/task-filters-cloud.component.ts 84.21% <75.00%> (-1.51%) ⬇️
...oud/src/lib/services/notification-cloud.service.ts 57.69% <100.00%> (-1.57%) ⬇️
lib/core/form/models/form-definition.model.ts
...ivities/diagram-alfresco-publish-task.component.ts
...m/components/gateways/diagram-gateway.component.ts
...ts/src/lib/diagram/models/diagram/diagram.model.ts
...onents/widgets/dynamic-table/editors/row.editor.ts
...re/form/events/validate-dynamic-table-row.event.ts
lib/core/buttons-menu/buttons-menu.component.ts
... and 512 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4fa193...510730d. Read the comment docs.

@eromano eromano merged commit afb5847 into develop Mar 29, 2021
@eromano eromano deleted the dev-dcano-ACA-4370 branch March 29, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants