[AAE-4428] Add selected file counter to attach file widget #6881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomikaArome
force-pushed
the
dev-thunter-AAE-4428
branch
from
30f18c0
to
19cdea6
Compare
TomikaArome
requested review from
DenysVuika,
eromano and
popovicsandras
as code owners
arditdomi
reviewed
Mar 30, 2021
lib/content-services/src/lib/content-node-selector/content-node-selector-panel.component.ts
Outdated
Show resolved
Hide resolved
TomikaArome
force-pushed
the
dev-thunter-AAE-4428
branch
from
19cdea6
to
3ef4721
Compare
arditdomi
suggested changes
Mar 30, 2021
lib/content-services/src/lib/content-node-selector/content-node-selector-panel.component.html
Outdated
Show resolved
Hide resolved
...content-services/src/lib/content-node-selector/content-node-selector-panel.component.spec.ts
Show resolved
Hide resolved
TomikaArome
force-pushed
the
dev-thunter-AAE-4428
branch
from
d49c582
to
2ec80b8
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6881 +/- ##
===========================================
+ Coverage 76.51% 78.51% +1.99%
===========================================
Files 885 211 -674
Lines 20219 5799 -14420
Branches 4030 1197 -2833
===========================================
- Hits 15471 4553 -10918
+ Misses 3509 894 -2615
+ Partials 1239 352 -887 Continue to review full report at Codecov.
|
arditdomi
reviewed
Apr 1, 2021
lib/content-services/src/lib/content-node-selector/content-node-selector.component.spec.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/content-node-selector/content-node-selector-panel.component.html
Outdated
Show resolved
Hide resolved
arditdomi
force-pushed
the
dev-thunter-AAE-4428
branch
from
ffdff86
to
bea2ca1
Compare
DenysVuika
approved these changes
Apr 15, 2021
eromano
requested changes
Apr 15, 2021
pr-triage
bot
added
PR: reviewed-changes-requested
and removed
PR: partially-approved
labels
TomikaArome
force-pushed
the
dev-thunter-AAE-4428
branch
from
e2747ab
to
ee8e1b2
Compare
Documentation added. Do we need to wait for the build again? It was green before. |
eromano
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
No way to tell exactly how many files are selected without counting them manually.
What is the new behaviour?
A counter in the toolbar to the right of the breadcrumb with the number of files selected is displayed.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: