Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADF-5363] - when aspects has no name we will show the id instead #6906

Merged
merged 2 commits into from Apr 9, 2021

Conversation

VitoAlbano
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
Aspect with no name set shows empty row

What is the new behaviour?
Aspect with no name set will shot on the list with id

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

codecov-io commented Apr 9, 2021

Codecov Report

Merging #6906 (f97cd5b) into develop (6eaf89a) will increase coverage by 1.99%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6906      +/-   ##
===========================================
+ Coverage    76.51%   78.51%   +1.99%     
===========================================
  Files          887      211     -676     
  Lines        20225     5799   -14426     
  Branches      4030     1197    -2833     
===========================================
- Hits         15476     4553   -10923     
+ Misses        3511      894    -2617     
+ Partials      1238      352     -886     
Impacted Files Coverage Δ
lib/core/mock/alfresco-api.service.mock.ts
lib/core/login/models/login-submit.event.ts
...onents/widgets/dynamic-table/editors/row.editor.ts
.../src/lib/site-dropdown/sites-dropdown.component.ts
...vices/src/lib/mock/document-list.component.mock.ts
...t-services/src/lib/breadcrumb/breadcrumb.module.ts
lib/core/form/models/form-definition.model.ts
lib/core/mock/bpm-user.service.mock.ts
lib/core/services/translation.service.ts
...core/datatable/components/data-row-action.event.ts
... and 665 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eaf89a...f97cd5b. Read the comment docs.

@eromano eromano merged commit 4b13ab7 into develop Apr 9, 2021
@eromano eromano deleted the dev-valbano-ADF-5363 branch April 9, 2021 15:00
TomikaArome pushed a commit that referenced this pull request Apr 9, 2021
)

* [ADF-5363] - when aspects has no name we will show the id instead

* added PR review fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants