New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADF-5363] - when aspects has no name we will show the id instead #6906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VitoAlbano
requested review from
DenysVuika,
eromano and
popovicsandras
as code owners
April 6, 2021 15:34
VitoAlbano
force-pushed
the
dev-valbano-ADF-5363
branch
from
April 7, 2021 08:06
462b15d
to
41cd969
Compare
arditdomi
reviewed
Apr 7, 2021
lib/content-services/src/lib/aspect-list/aspect-list.component.html
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/aspect-list/aspect-list.component.html
Outdated
Show resolved
Hide resolved
eromano
requested changes
Apr 7, 2021
lib/content-services/src/lib/aspect-list/aspect-list.component.html
Outdated
Show resolved
Hide resolved
arditdomi
approved these changes
Apr 9, 2021
eromano
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
Aspect with no name set shows empty row
What is the new behaviour?
Aspect with no name set will shot on the list with id
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: