Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-4966] Extensible app config #6914

Merged
merged 9 commits into from Apr 13, 2021
Merged

[AAE-4966] Extensible app config #6914

merged 9 commits into from Apr 13, 2021

Conversation

DenysVuika
Copy link
Contributor

@DenysVuika DenysVuika commented Apr 9, 2021

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

  • support for updating App Config from the extensions ("appConfig" property)
  • cleanup the incorrect usage of the service injection in ADF unit tests (stability and less refactorings in the future)

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://alfresco.atlassian.net/browse/AAE-4966

@mauriziovitale
Copy link
Contributor

Do we have an issue linked that contains the AC? Once merged, who is gonna test it and based on what? We should have examples and expectations
fileExtension1
fileExtension2

result

@DenysVuika
Copy link
Contributor Author

DenysVuika commented Apr 12, 2021

@mauriziovitale the issue is https://alfresco.atlassian.net/browse/AAE-4966

This code is needed for https://alfresco.atlassian.net/browse/AAE-4842. The service has unit tests, the corresponding UI in the Modeling app will be testable.

@DenysVuika DenysVuika changed the title Extensible app config [AAE-4966] Extensible app config Apr 12, 2021
@codecov-io
Copy link

Codecov Report

Merging #6914 (159a330) into develop (c120526) will increase coverage by 0.08%.
The diff coverage is 80.00%.

❗ Current head 159a330 differs from pull request most recent head 62f139d. Consider uploading reports for the commit 62f139d to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6914      +/-   ##
===========================================
+ Coverage    76.56%   76.65%   +0.08%     
===========================================
  Files          887      887              
  Lines        20227    20272      +45     
  Branches      4030     4042      +12     
===========================================
+ Hits         15487    15539      +52     
+ Misses        3499     3488      -11     
- Partials      1241     1245       +4     
Impacted Files Coverage Δ
lib/core/app-config/debug-app-config.service.ts 12.50% <0.00%> (ø)
lib/core/testing/core.testing.module.ts 100.00% <ø> (ø)
...ib/testing/process-service-cloud.testing.module.ts 100.00% <ø> (ø)
...services/src/lib/testing/process.testing.module.ts 100.00% <ø> (ø)
lib/core/app-config/app-config.service.ts 88.00% <83.33%> (-0.58%) ⬇️
lib/core/mock/alfresco-api.service.mock.ts 88.88% <100.00%> (ø)
lib/core/mock/app-config.service.mock.ts 100.00% <100.00%> (ø)
lib/core/mock/search.service.mock.ts 100.00% <100.00%> (ø)
...b/extensions/src/lib/services/extension.service.ts 83.60% <100.00%> (+0.84%) ⬆️
...ib/process-list/services/process-filter.service.ts 90.90% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c120526...62f139d. Read the comment docs.

Copy link
Contributor

@pmartinezga pmartinezga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

@DenysVuika DenysVuika merged commit 84ce202 into develop Apr 13, 2021
@DenysVuika DenysVuika deleted the extensible-app-config branch April 13, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants