Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADF-5362] - Content type properties should be showed when content type is changed. #6922

Merged
merged 4 commits into from Apr 15, 2021

Conversation

VitoAlbano
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

codecov-io commented Apr 13, 2021

Codecov Report

Merging #6922 (90aba62) into develop (be355cc) will increase coverage by 1.88%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6922      +/-   ##
===========================================
+ Coverage    76.62%   78.51%   +1.88%     
===========================================
  Files          887      211     -676     
  Lines        20261     5799   -14462     
  Branches      4040     1197    -2843     
===========================================
- Hits         15526     4553   -10973     
+ Misses        3489      894    -2595     
+ Partials      1246      352     -894     
Impacted Files Coverage Δ
lib/core/form/components/form-base.component.ts
lib/core/form/services/node.service.ts
lib/core/data-column/data-column.component.ts
...ore/card-view/services/card-view-update.service.ts
...onents/activities/diagram-manual-task.component.ts
lib/core/mock/renditions-service.mock.ts
...b/core/viewer/services/rendering-queue.services.ts
...s/widgets/core/upload-widget-content-link.model.ts
lib/content-services/src/lib/material.module.ts
...lect-filter-input/select-filter-input.component.ts
... and 660 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd82429...90aba62. Read the comment docs.

@eromano eromano merged commit e4288cd into develop Apr 15, 2021
@eromano eromano deleted the dev-valbano-ADF-5362-properties branch April 15, 2021 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants