Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-5122] Change mouse event to leave in tooltip card #6978

Merged
merged 1 commit into from May 6, 2021

Conversation

pmartinezga
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
When the tooltip card is attached to an element, if that element has children and the mouse cursor is moved inside the parent to a child, the mouseout event is fired, and the tooltip is hidden.

What is the new behaviour?
We use the mouseleave event so only when the mouse cursor leave the parent, the tooltip card is hidden, but the user can move the cursor inside the parent and the tooltip is still there

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@pmartinezga pmartinezga merged commit 12652b5 into develop May 6, 2021
@pmartinezga pmartinezga deleted the dev-pmartinezga-AAE-5122-fix-tooltip branch May 6, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants