Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT-22334] ADW - User information not displayed when Kerberos is in use #7172

Merged
merged 4 commits into from
Aug 2, 2021
Merged

[MNT-22334] ADW - User information not displayed when Kerberos is in use #7172

merged 4 commits into from
Aug 2, 2021

Conversation

dhrn
Copy link
Contributor

@dhrn dhrn commented Jul 13, 2021 •
edited

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

https://alfresco.atlassian.net/browse/MNT-22334

What is the new behaviour?

image

fixed

I have tested using this repo -> https://github.com/dhrn/alfresco-kerberos

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@pr-triage pr-triage bot added the PR: draft label Jul 13, 2021
@dhrn dhrn requested a review from eromano July 13, 2021 08:58
@eromano
Copy link
Contributor

eromano commented Jul 13, 2021

can you provide some unit test?

@dhrn dhrn marked this pull request as ready for review July 20, 2021 06:57
@eromano eromano merged commit 4befb77 into develop Aug 2, 2021
@eromano eromano deleted the dev-dhrn-MNT-22334 branch August 2, 2021 09:30
dhrn pushed a commit that referenced this pull request Oct 1, 2021
Revert "[MNT-22334] ADW - User information not displayed when Kerbero…
9fd75ce 
…s is in use (#7172)"

This reverts commit 4befb77
eromano pushed a commit that referenced this pull request Oct 5, 2021
@dhrn
[ADF-5465] Not being redirected to login page when Kerberos is enabled (
8a3c49e 
#7272)

* Revert "[MNT-22334] ADW - User information not displayed when Kerberos is in use (#7172)"

This reverts commit 4befb77

* [ADF-5465] Not being redirected to login page when Kerberos is enabled

* * fix user info

* * add providers

* * fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenysVuika DenysVuika DenysVuika approved these changes

@eromano eromano eromano approved these changes

@popovicsandras popovicsandras Awaiting requested review from popovicsandras popovicsandras is a code owner

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dhrn @eromano @DenysVuika