[AAE-6057] Customize text color in the header #7325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BSekula
requested review from
DenysVuika,
eromano and
popovicsandras
as code owners
|
|
BSekula
commented
Oct 27, 2021
BSekula
force-pushed
the
dev-bsekula-AAE-6057-header-text-color
branch
from
9eae745
to
05736d5
Compare
eromano
requested changes
Oct 27, 2021
| /** | ||
| * Text color for the header. Should be hex color code | ||
| */ | ||
| @Input() textColor: string; |
There was a problem hiding this comment.
can you be sure the doc get rebuilded as well using the command npm run docbuild
There was a problem hiding this comment.
Added documentation
There was a problem hiding this comment.
I don't like this solution, in my opinion all the font/color changes should be driven by the adf palette. What's the plan to pollute every component like CardView/Navigation Bar/Breadcrumbs with additional options to change the color/font/size?
There was a problem hiding this comment.
Updated as discussed
pr-triage
bot
added
PR: reviewed-changes-requested
PR: unreviewed
and removed
PR: unreviewed
PR: reviewed-changes-requested
labels
eromano
approved these changes
Oct 28, 2021
This reverts commit 1915535.
BSekula
force-pushed
the
dev-bsekula-AAE-6057-header-text-color
branch
from
41e68ca
to
a42d462
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/AAE-6057
What is the new behaviour?
adf-layout-headercan consume new argument for changing text colorDoes this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: