Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADF-4915][Form] FormField: When required is set to true, asterisk apppears in placeholder text #7399

Merged
merged 2 commits into from
Nov 30, 2021

Conversation

dhrn
Copy link
Contributor

@dhrn dhrn commented Nov 30, 2021

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
image

https://alfresco.atlassian.net/browse/ADF-4915

What is the new behaviour?
image

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@andrea-ligios andrea-ligios changed the title [ADF-4915][Form] FormField: When required is set to true, asterix app… [ADF-4915][Form] FormField: When required is set to true, asterisk apppears in placeholder text Nov 30, 2021
Copy link
Member

@andrea-ligios andrea-ligios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eromano eromano merged commit 2b25b50 into develop Nov 30, 2021
@eromano eromano deleted the dev-dhrn-ADF-4915 branch November 30, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants