Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADF-5467 re-enable test #7455

Merged
merged 1 commit into from
Jan 24, 2022
Merged

ADF-5467 re-enable test #7455

merged 1 commit into from
Jan 24, 2022

Conversation

jesty
Copy link
Contributor

@jesty jesty commented Jan 18, 2022

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@pr-triage pr-triage bot added the PR: draft label Jan 18, 2022
@jesty jesty marked this pull request as ready for review January 18, 2022 14:18
@jesty jesty requested a review from eromano as a code owner January 18, 2022 14:18
@andrea-ligios andrea-ligios self-requested a review January 21, 2022 11:17
andrea-ligios
andrea-ligios requested changes Jan 21, 2022
View reviewed changes
Copy link
Member

@andrea-ligios andrea-ligios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title is wrong, it's ADF-5467 not ADF-5497

@jesty jesty changed the title ADF-5497 re-enable test ADF-5467 re-enable test Jan 21, 2022
andrea-ligios
andrea-ligios approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@andrea-ligios andrea-ligios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jesty jesty merged commit d605efa into develop Jan 24, 2022
@jesty jesty deleted the dev-dcerbo-ADF-5467-fix-test branch January 24, 2022 08:33
@pr-triage pr-triage bot added the PR: merged label Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrea-ligios andrea-ligios andrea-ligios approved these changes

@miguelruizdev miguelruizdev miguelruizdev approved these changes

@eromano eromano Awaiting requested review from eromano eromano is a code owner

Assignees
No one assigned
Labels
do not merge 🙅🏻‍♂️ PR: draft PR: merged PR: partially-approved PR: reviewed-changes-requested PR: unreviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jesty @andrea-ligios @miguelruizdev