[AAE-7035] Being able to load a dynamic file location #7456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauriziovitale
requested review from
DenysVuika,
eromano and
popovicsandras
as code owners
popovicsandras
requested changes
Jan 18, 2022
| @@ -19,7 +19,7 @@ | |||
| export const ACTIVITI_CLOUD_APPS: any = { | |||
| SUB_PROCESS_APP: { | |||
| name: 'subprocessapp', | |||
| file_location: 'https://github.com/Alfresco/alfresco-ng2-components/blob/develop/e2e/resources/activiti7/subprocessapp.zip?raw=true', | |||
| file_location: (TAG = 'develop') => `https://github.com/Alfresco/alfresco-ng2-components/blob/${TAG}/e2e/resources/activiti7/subprocessapp.zip?raw=true`, | |||
There was a problem hiding this comment.
Previously we were using it as a normal property, now as a function. How doesn't it cause any problem with other parts of the app without making changes even there?
There was a problem hiding this comment.
this file is only used by init-aae-env command
There was a problem hiding this comment.
what a pleasure!
arditdomi
approved these changes
Jan 18, 2022
DenysVuika
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: