Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-6310] Fix for attaching files #7457

Merged
merged 4 commits into from
Jan 24, 2022

Conversation

BSekula
Copy link
Contributor

@BSekula BSekula commented Jan 19, 2022

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/AAE-6310

After navigate to process page with query params for process i.e. process="my-proess-name" form and attached files were not shown

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

*ngFor="let processDef of filteredProcesses"
[value]="getProcessDefinitionValue(processDef)"
(click)="processDefinitionSelectionChanged(processDef)"
>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indention only

@BSekula BSekula requested a review from Qetikv January 19, 2022 11:50
@eromano
Copy link
Contributor

eromano commented Jan 20, 2022

@BSekula can we avoid the indentation change? let's keep only the needed changes thanks

Copy link
Contributor

@eromano eromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented added

@BSekula
Copy link
Contributor Author

BSekula commented Jan 20, 2022

reverted indentation changes

@BSekula BSekula requested a review from eromano January 20, 2022 10:25
@BSekula BSekula force-pushed the dev-bsekula-AAE-6310-fix-attach-files branch from 6d7fac3 to 8eb32a5 Compare January 24, 2022 10:01
@BSekula BSekula merged commit bf77663 into develop Jan 24, 2022
@BSekula BSekula deleted the dev-bsekula-AAE-6310-fix-attach-files branch January 24, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants