-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AAE-6310] Fix for attaching files #7457
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BSekula
requested review from
DenysVuika,
eromano and
popovicsandras
as code owners
January 19, 2022 11:47
BSekula
commented
Jan 19, 2022
*ngFor="let processDef of filteredProcesses" | ||
[value]="getProcessDefinitionValue(processDef)" | ||
(click)="processDefinitionSelectionChanged(processDef)" | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indention only
Qetikv
approved these changes
Jan 19, 2022
@BSekula can we avoid the indentation change? let's keep only the needed changes thanks |
eromano
requested changes
Jan 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commented added
pr-triage
bot
added
PR: reviewed-changes-requested
PR: unreviewed
and removed
PR: partially-approved
PR: reviewed-changes-requested
labels
Jan 20, 2022
BSekula
force-pushed
the
dev-bsekula-AAE-6310-fix-attach-files
branch
4 times, most recently
from
January 20, 2022 10:24
04c2177
to
81c2b05
Compare
reverted indentation changes |
eromano
approved these changes
Jan 20, 2022
BSekula
force-pushed
the
dev-bsekula-AAE-6310-fix-attach-files
branch
from
January 20, 2022 16:29
8a64863
to
6d7fac3
Compare
BSekula
force-pushed
the
dev-bsekula-AAE-6310-fix-attach-files
branch
from
January 24, 2022 10:01
6d7fac3
to
8eb32a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/AAE-6310
After navigate to process page with query params for process i.e.
process="my-proess-name"
form and attached files were not shownWhat is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: