Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-10202] Storybook EmptyContent component #7745

Merged
merged 6 commits into from
Aug 17, 2022
Merged

Conversation

marcol13
Copy link
Contributor

@marcol13 marcol13 commented Aug 4, 2022

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/AAE-10202

What is the new behaviour?
Two new stories for Core EmptyContent component:

  • Default story:
    image

  • Story with multiple message lines:
    image

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@pr-triage pr-triage bot added the PR: draft label Aug 4, 2022
@CLAassistant
Copy link

CLAassistant commented Aug 4, 2022

CLA assistant check
All committers have signed the CLA.

@marcol13
Copy link
Contributor Author

marcol13 commented Aug 5, 2022

Stories preview:

Screenshare.-.2022-08-05.8_47_33.AM.mp4

@marcol13 marcol13 changed the title [10202] Storybook EmptyContent component [AAE-10202] Storybook EmptyContent component Aug 8, 2022
@marcol13 marcol13 merged commit d3129e2 into develop Aug 17, 2022
@marcol13 marcol13 deleted the dev-mkrueger-AAE-10202 branch August 17, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants